add compatibility with 2.10

scrapinghub · Sep 20, 2023 · e76f2b9 · e76f2b9
1 parent d8b6ff6
commit e76f2b9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       matrix:
         python-version: ["3.8", "3.9", "3.10", "3.11"]
-        scrapy-version: ["2.11"]
+        scrapy-version: ["2.11", "2.10"]
 
     steps:
     - uses: actions/checkout@v2

diff --git a/scrapyrt/core.py b/scrapyrt/core.py
@@ -39,8 +39,9 @@ def crawl(self, *args, **kwargs):
         self.crawling = True
         try:
             self.spider = self._create_spider(*args, **kwargs)
-            self._apply_settings()
-            self._update_root_log_handler()
+            if hasattr(self, "_apply_settings"):
+                self._apply_settings()
+                self._update_root_log_handler()
             self.engine = self._create_engine()
             if self.start_requests:
                 start_requests = iter(self.spider.start_requests())

diff --git a/setup.py b/setup.py
@@ -41,7 +41,7 @@
         "Tracker": "https://github.com/scrapinghub/scrapyrt/issues"
     },
     install_requires=[
-        'Scrapy>=2.11'
+        'Scrapy>=2.10'
     ],
     package_data={
         'scrapyrt': [