Merge pull request #936 from scrapinghub/fix-notebook

Fix splash-jupyter

dockerfiles/splash-jupyter/Dockerfile

@@ -2,6 +2,7 @@ FROM scrapinghub/splash:master
 # XXX: after each release a new branch named X.Y should be created,
 # and FROM should be changed to FROM scrapinghub/splash:X.Y
 
+USER root:root
 RUN apt-get update -q && \
     apt-get install --no-install-recommends -y \
         libzmq3-dev \
@@ -16,13 +17,15 @@ RUN apt-get update -q && \
 # ADD . /app
 RUN pip3 install -r /app/requirements-jupyter.txt
 # RUN pip3 freeze
+RUN mkdir /notebooks & chown splash:splash /notebooks
+USER splash:splash
 
 RUN python3 -m splash.kernel install && \
-    echo '#!/bin/bash\nSPLASH_ARGS="$@" jupyter notebook --allow-root --no-browser --NotebookApp.iopub_data_rate_limit=10000000000 --port=8888 --ip=0.0.0.0' > start-notebook.sh && \
-    chmod +x start-notebook.sh
+    echo '#!/bin/bash\nSPLASH_ARGS="$@" jupyter notebook --allow-root --no-browser --NotebookApp.iopub_data_rate_limit=10000000000 --port=8888 --ip=0.0.0.0' > /app/start-notebook.sh && \
+    chmod +x /app/start-notebook.sh
 
 VOLUME /notebooks
 WORKDIR /notebooks
 
 EXPOSE 8888
-ENTRYPOINT ["/start-notebook.sh"]
+ENTRYPOINT ["/app/start-notebook.sh"]

requirements-jupyter.txt

@@ -1,11 +1,13 @@
-ipykernel==5.1.0
-ipython==7.2.0
+ipykernel==5.1.2
+ipython==7.7.0
 ipython-genutils==0.2.0
-ipywidgets==7.4.2
+ipywidgets==7.5.1
 jupyter==1.0.0
-jupyter-client==5.2.4
+jupyter-client==5.3.1
 jupyter-console==6.0.0
-jupyter-core==4.4.0
-nbconvert==5.4.0
+jupyter-core==4.5.0
+nbconvert==5.6.0
 nbformat==4.4.0
-notebook==5.7.4
+notebook==5.7.8
+tornado < 6.0
+widgetsnbextension==3.5.1