Fix typing issues for typed Scrapy. #131
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 97.86% 97.88% +0.01%
==========================================
Files 14 14
Lines 1590 1605 +15
Branches 294 294
==========================================
+ Hits 1556 1571 +15
Misses 14 14
Partials 20 20
|
wRAR
commented
Sep 21, 2023
| @@ -188,8 +192,8 @@ def _process_response( | |||
|
|
|||
| if api_response.get("httpResponseHeaders") and api_response.get("httpResponseBody"): | |||
| response_cls = responsetypes.from_args( | |||
| headers=api_response["httpResponseHeaders"], | |||
| url=api_response["url"], | |||
| headers=cast(List[Dict[str, str]], api_response["httpResponseHeaders"]), | |||
There was a problem hiding this comment.
This produces an error which looks valid: api_response["httpResponseHeaders"] is a list of dicts with "name" and "value" keys while ResponseTypes.from_headers expects a Mapping[bytes, bytes] (not even strings).
There was a problem hiding this comment.
We’ll need to address that.
Gallaecio
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.