-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace spmatrix with _CSMatrix as appropriate #3431
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3431 +/- ##
==========================================
+ Coverage 75.36% 75.43% +0.06%
==========================================
Files 112 112
Lines 13219 13235 +16
==========================================
+ Hits 9963 9984 +21
+ Misses 3256 3251 -5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, about the plan:
replace spmatrix with _SpBase = sparray | spmatrix and _CSMatrix with _CSBase = cs{cr}_matrix | cs{cr}_array and test
I am not sure this will go so smoothly because of differing APIs and version compatibility. It was something of a nightmare in AnnData
...
Preparation for sparray support: make sure
spmatrix
is only used where it makes sense.I checked every single instance of
spmatrix
and either tested thatcoo_matrix
also works or replaced it with_CSMatrix = csr_matrix | csc_matrix
.TODO after this PR:
_SpBase = sparray | spmatrix
and_CSMatrix
with_CSBase = cs{cr}_matrix | cs{cr}_array
and testbsr_array