Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): import skimage early in scublets without threshold #3463

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Feb 12, 2025

  • Release notes not necessary because: No behavior change

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (3075537) to head (e20b106).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3463   +/-   ##
=======================================
  Coverage   75.44%   75.45%           
=======================================
  Files         113      113           
  Lines       13250    13251    +1     
=======================================
+ Hits         9997     9998    +1     
  Misses       3253     3253           
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_scrublet/__init__.py 96.84% <100.00%> (+0.03%) ⬆️

@ilan-gold ilan-gold added this to the 1.12.0 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issue: sc.pp.scrublet require skimage implicitly
1 participant