Faster filtering of sparce matrix #3465
Open
+82
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for faster filtering of sparce matrix. We have tested is on AWS c7i.24xlarge.
Orignal Output
Total filter min_genes_per_cell : 175.78095293045044
Total filter max_genes_per_cell : 66.684401512146
Total filter genes : 60.77386426925659
Output with our code
Total filter min_genes_per_cell : 131.49908232688904
Total filter max_genes_per_cell : 24.586800575256348
Total filter genes : 32.83677649497986
So in total it is around 37% faster in case of sparce matrix
We have one failed test case which is failing in both
main
branch and in our branchPlease tell me how can i fix this failed check
![Opera Snapshot_2025-02-13_102118_github com](https://private-user-images.githubusercontent.com/9661614/412725022-739ed6a8-91a4-4f3d-a8e8-99f02d87c613.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODY4MTUsIm5iZiI6MTczOTU4NjUxNSwicGF0aCI6Ii85NjYxNjE0LzQxMjcyNTAyMi03MzllZDZhOC05MWE0LTRmM2QtYThlOC05OWYwMmQ4N2M2MTMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDIyODM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTJmMjJmMTM4ZWJkYzdjMjZhNzU0YTBkNWExODc3ODY5MDdmYThlYjM5Y2RhZGE5MjQ5ZjgzNmNjMTE0YzkwYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.tu2ALHjQ_KG4-Zs1YT7HhRuITF8KBtrwI0bEeMg1ZDo)