fix buildToNodeHandler, refactor node <-> edge bridge code
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codetheweb
reviewed
Jan 16, 2024
| }) | ||
| res.end(await fetchResponse.text()) | ||
| }) | ||
| ) |
There was a problem hiding this comment.
this should have been documented better, but we don't want to run within the edge runtime here--this is for when you're targeting Node, either because you want to use Node APIs or you're unable to use the edge runtime (I think you might not be allowed to use it in Vercel endpoints)
There was a problem hiding this comment.
Ah, I see! I'll revert this in a future pr 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
buildToNodeHandlerby introducing a workaround for vercel/edge-runtime#716 (see here)Then I've used this wherever we've manually written code that bridges edge runtime with node. The result is significantly cleaner and probably much less error prone 😉
cc @seveibar