add module service adapter, unify route handling to handleRequestWithEdgeSpec
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codetheweb
reviewed
Jan 19, 2024
codetheweb
reviewed
Jan 19, 2024
codetheweb
reviewed
Jan 19, 2024
mxsdev
commented
Jan 19, 2024
codetheweb
approved these changes
Jan 19, 2024
|
|
||
| export type ModuleService = (options?: ModuleServiceOptions) => EdgeSpecRouteFn | ||
|
|
||
| export const createModuleService: EdgeSpecAdapter<[], ModuleService> = ( |
There was a problem hiding this comment.
🐧 I kinda like
Suggested change
| export const createModuleService: EdgeSpecAdapter<[], ModuleService> = ( | |
| export const createEmbeddedService: EdgeSpecAdapter<[], EmbeddedService> = ( |
but don't want to bikeshed too much
There was a problem hiding this comment.
will deal with this in follow-up discussions/PRs/RFCs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EdgeSpec, once constructed, is almost always used as a function(request: Request, pathname: string) => Response. So I introducedhandleRequestWithEdgeSpec, which enables this functionality.I also introduced the code for module services here, which I wrote as a kind of adapter that takes an
EdgeSpecand returns a function for anEdgeSpecRouteFn. I introduced ahandle404function toEdgeSpecin order to exemplify cascading options, so that e.g. 404 configs pass down to child routes.