-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edgespec bundle
CLI
#25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice 👍
export class BundleCommand extends Command { | ||
static paths = [[`bundle`]] | ||
|
||
static usage = Command.Usage({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adapter config will be added later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly, by default this is outputting a file that can either be used for an embedded/module service or you can create your own 3 loc entrypoint importing the bundle
maybe eventually an option to embed the adapter would be nice too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right, I'm getting things mixed up, this just exports the "route bundle"
I guess I'm a little confused because bundle
takes a "bundledAdapter" option which can bundle the wintercg adapter....is that even needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'm adding a todo comment about that option in my next PR
we do need it but it's only used internally for dev and test fixtures so 🤷
Closes #6. Also bumps some dependencies.