Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edgespec bundle CLI #25

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Add edgespec bundle CLI #25

merged 6 commits into from
Jan 22, 2024

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Jan 22, 2024

Closes #6. Also bumps some dependencies.

Screenshot 2024-01-22 at 12 17 01
Screenshot 2024-01-22 at 12 21 25

@codetheweb codetheweb marked this pull request as ready for review January 22, 2024 20:36
@codetheweb codetheweb requested a review from mxsdev January 22, 2024 20:36
Copy link
Contributor

@mxsdev mxsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice 👍

tests/fixtures/get-test-cli.ts Show resolved Hide resolved
export class BundleCommand extends Command {
static paths = [[`bundle`]]

static usage = Command.Usage({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapter config will be added later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly, by default this is outputting a file that can either be used for an embedded/module service or you can create your own 3 loc entrypoint importing the bundle

maybe eventually an option to embed the adapter would be nice too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, I'm getting things mixed up, this just exports the "route bundle"

I guess I'm a little confused because bundle takes a "bundledAdapter" option which can bundle the wintercg adapter....is that even needed anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'm adding a todo comment about that option in my next PR
we do need it but it's only used internally for dev and test fixtures so 🤷

@codetheweb codetheweb merged commit fe9f94b into main Jan 22, 2024
9 checks passed
@codetheweb codetheweb deleted the feat-cli-bundle branch January 22, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add edgespec bundle command
2 participants