-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Default TLS encryption on Trillian services #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: osmman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8e1dda7
to
d1f7e17
Compare
988b996
to
1a82c22
Compare
1a82c22
to
09b3f88
Compare
bouskaJ
reviewed
Mar 3, 2025
49cbc9b
to
0d33cbe
Compare
/test tas-operator-e2e |
bouskaJ
reviewed
Mar 4, 2025
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables TLS communication on the Trillian service, making it the default for OpenShift deployments. The implementation requires a rework of the process for creating Trillian trees to leverage Kubernetes Jobs.
Key Changes:
Resolve tree action
The "resolve tree" action manages the creation of Merkle trees using the Trillian service. It includes setting up required resources, launching, and monitoring the creation process, and updating the custom resource with the new tree information.
Workflow:
Additional Information:
This pull request is based on the previous work done by @fghanmi in PR #493.