Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Default TLS encryption on Trillian services #871

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Feb 20, 2025

This pull request enables TLS communication on the Trillian service, making it the default for OpenShift deployments. The implementation requires a rework of the process for creating Trillian trees to leverage Kubernetes Jobs.

Key Changes:

  • Enabled TLS communication on Trillian services
  • Reworked the creation process of Trillian trees to leverage Kubernetes Jobs.
  • Updated relevant configurations and code to support the new TLS-enabled setup.
flowchart TD
    rekor -->|grpc| trillian-logserver
    ctlog -->|grpc| trillian-logserver
    createtree -->|grpc| trillian-logserver
    trillian-logsigner
Loading

Resolve tree action

The "resolve tree" action manages the creation of Merkle trees using the Trillian service. It includes setting up required resources, launching, and monitoring the creation process, and updating the custom resource with the new tree information.

Workflow:

  1. Check Tree Status: Verify if the tree is already resolved.
  2. Prepare Environment: Create/update RBAC resources and set up a ConfigMap for the tree creation job.
  3. Launch Job: Submit a Kubernetes Job to execute the Trillian tree creation script with necessary configurations.
  4. Monitor Job: Wait for job completion and handle its status.
  5. Process Results: Extract and update the TreeID in the custom resource status.

Additional Information:

This pull request is based on the previous work done by @fghanmi in PR #493.

@openshift-ci openshift-ci bot requested review from JasonPowr and lance February 20, 2025 12:48
Copy link

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osmman osmman force-pushed the tturek/trillian-tls branch 2 times, most recently from 8e1dda7 to d1f7e17 Compare February 20, 2025 16:09
@osmman osmman requested review from bouskaJ and fghanmi February 20, 2025 17:30
@osmman osmman force-pushed the tturek/trillian-tls branch 2 times, most recently from 988b996 to 1a82c22 Compare February 24, 2025 14:03
@osmman osmman added this to the 1.2.0 milestone Feb 25, 2025
@osmman osmman force-pushed the tturek/trillian-tls branch from 1a82c22 to 09b3f88 Compare February 25, 2025 12:47
@osmman osmman force-pushed the tturek/trillian-tls branch from 49cbc9b to 0d33cbe Compare March 3, 2025 14:28
@osmman osmman requested a review from bouskaJ March 3, 2025 14:53
@osmman
Copy link
Contributor Author

osmman commented Mar 3, 2025

/test tas-operator-e2e

@bouskaJ
Copy link
Collaborator

bouskaJ commented Mar 4, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 95f9851 into main Mar 4, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants