test: Use explicit ipv4 address instead of localhost when waiting on URLs
#763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
askoufis
changed the title
localhost when waiting on URLslocalhost when waiting on URLs
askoufis
changed the title
localhost when waiting on URLslocalhost when waiting on URLs
michaeltaranto
approved these changes
Apr 11, 2023
mrm007
reviewed
Apr 11, 2023
| .replace(/http(s?)\:/, 'http$1-get:') | ||
| // As of node 17, ipv6 is preferred, so explicitly use ipv4 | ||
| // See https://github.com/jeffbski/wait-on/issues/133 | ||
| .replace(/localhost/, '127.0.0.1'), |
There was a problem hiding this comment.
Does it work with this?
Suggested change
| .replace(/localhost/, '127.0.0.1'), | |
| .replace(/localhost/, '0.0.0.0'), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All our fixture tests use
localhostin URLs. Some tests were failing locally for me because of this. This has to do with node 17+ preferring ipv6 over ipv4. See jeffbski/wait-on#133 for more info. We're pinning node 16 in sku though, so it's odd that this is even an issue.Ideally we'd make webpack dev server listen on both ipv4 localhost and ipv6 localhost, but I'm not sure how to configure that. Others are welcome to try. https://webpack.js.org/configuration/dev-server/#devserverhost