include and fix observation unit #2124

seek4science · Jan 30, 2025 · 685ec25 · 685ec25
1 parent 2ec4fec
commit 685ec25
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/app/models/observation_unit.rb b/app/models/observation_unit.rb
@@ -33,14 +33,6 @@ def contributors
     [contributor]
   end
 
-  def is_in_isa_publishable?
-    false
-  end
-
-  def can_publish?
-    false
-  end
-
   def related_people
     (creators + contributors).compact.uniq
   end

diff --git a/test/unit/permissions/publishing_permissions_test.rb b/test/unit/permissions/publishing_permissions_test.rb
@@ -52,7 +52,7 @@ class PublishingPermissionsTest < ActiveSupport::TestCase
       refute item.gatekeeper_required?
 
       case item.class.name
-      when 'Study', 'Assay'
+      when 'Study', 'Assay', 'ObservationUnit'
         disable_authorization_checks { item.investigation.projects = gatekeeper.projects }
       else
         disable_authorization_checks { item.projects = gatekeeper.projects }
@@ -371,12 +371,17 @@ def items_for_publishing_tests(contributor = FactoryBot.create(:person))
       FactoryBot.create(type, contributor: contributor, projects: contributor&.projects)
     end
 
+    #projects handled differently
     study = FactoryBot.create(:study, contributor: contributor,
                               investigation: FactoryBot.create(:investigation, projects: contributor&.projects)
     )
     assay = FactoryBot.create(:assay, contributor: contributor, study:
       FactoryBot.create(:study, contributor: contributor, investigation: FactoryBot.create(:investigation, projects: contributor&.projects))
     )
-    items | [study, assay]
+    obs_unit = FactoryBot.create(:observation_unit, contributor: contributor, policy: FactoryBot.create(:private_policy), study:
+      FactoryBot.create(:study, contributor: contributor, investigation: FactoryBot.create(:investigation, projects: contributor&.projects))
+    )
+    items | [study, assay, obs_unit]
+    [obs_unit]
   end
 end