Fix "No url defined in config file" when using ESM
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into an issue where I could now longer migrate because I was getting the error:
ERROR: Nourldefined in config file! Error: Nourldefined in config file!.The issue is that the code for handling importing the config file when it is ESM assumes that node will throw an error when you try to require an ESM file. That error was no longer being thrown and the returned module was all nested under
default. As result, it couldn't find theurl.This PR, correctly handles this case.
Checklist
npm testpasses and has 100% coverage