Skip to content

Commit

Permalink
Correct tests which should've failed to expect failures now that they…
Browse files Browse the repository at this point in the history
… fail
  • Loading branch information
kayabaNerve committed Jul 12, 2024
1 parent 4ba961b commit 32c2491
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions coins/monero/wallet/src/tests/extra.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,13 @@ fn padding_only_max_size() {
#[test]
fn padding_only_exceed_max_size() {
let buf: Vec<u8> = vec![0; MAX_TX_EXTRA_PADDING_COUNT + 1];
let extra = Extra::read::<&[u8]>(&mut buf.as_ref()).unwrap();
assert!(extra.0.is_empty());
Extra::read::<&[u8]>(&mut buf.as_ref()).unwrap_err();
}

#[test]
fn invalid_padding_only() {
let buf: Vec<u8> = vec![0, 42];
let extra = Extra::read::<&[u8]>(&mut buf.as_ref()).unwrap();
assert!(extra.0.is_empty());
Extra::read::<&[u8]>(&mut buf.as_ref()).unwrap_err();
}

#[test]
Expand All @@ -137,8 +135,7 @@ fn extra_nonce_only_wrong_size() {
let mut buf: Vec<u8> = vec![0; 20];
buf[0] = 2;
buf[1] = 255;
let extra = Extra::read::<&[u8]>(&mut buf.as_ref()).unwrap();
assert!(extra.0.is_empty());
Extra::read::<&[u8]>(&mut buf.as_ref()).unwrap_err();
}

#[test]
Expand All @@ -158,8 +155,7 @@ fn pub_key_and_padding() {
fn pub_key_and_invalid_padding() {
let mut buf: Vec<u8> = PUB_KEY_BYTES.to_vec();
buf.extend([0, 1]);
let extra = Extra::read::<&[u8]>(&mut buf.as_ref()).unwrap();
assert_eq!(extra.0, vec![ExtraField::PublicKey(pub_key())]);
Extra::read::<&[u8]>(&mut buf.as_ref()).unwrap_err();
}

#[test]
Expand All @@ -185,8 +181,7 @@ fn extra_mysterious_minergate_only_wrong_size() {
let mut buf: Vec<u8> = vec![0; 20];
buf[0] = 222;
buf[1] = 255;
let extra = Extra::read::<&[u8]>(&mut buf.as_ref()).unwrap();
assert!(extra.0.is_empty());
Extra::read::<&[u8]>(&mut buf.as_ref()).unwrap_err();
}

#[test]
Expand Down

0 comments on commit 32c2491

Please sign in to comment.