Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slash bad validators #468

Merged
merged 10 commits into from
Dec 16, 2023
Merged

Slash bad validators #468

merged 10 commits into from
Dec 16, 2023

Conversation

akildemir
Copy link
Contributor

No description provided.

kayabaNerve
kayabaNerve requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@kayabaNerve kayabaNerve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a series of complex changes. I do get some of these will be inevitable.

substrate/validator-sets/pallet/src/lib.rs Show resolved Hide resolved
substrate/runtime/src/lib.rs Outdated Show resolved Hide resolved
substrate/validator-sets/pallet/src/lib.rs Outdated Show resolved Hide resolved
substrate/validator-sets/pallet/src/lib.rs Outdated Show resolved Hide resolved
substrate/validator-sets/pallet/src/lib.rs Outdated Show resolved Hide resolved
substrate/runtime/src/lib.rs Show resolved Hide resolved
substrate/validator-sets/pallet/src/lib.rs Show resolved Hide resolved
substrate/validator-sets/pallet/src/lib.rs Outdated Show resolved Hide resolved
substrate/validator-sets/pallet/src/lib.rs Outdated Show resolved Hide resolved
substrate/validator-sets/pallet/src/lib.rs Outdated Show resolved Hide resolved
@kayabaNerve
Copy link
Member

Rebased onto develop. Working on reviewing.

@kayabaNerve
Correct rebase artifacts I introduced
e57798d
@kayabaNerve
Cleanups and corrections
1050356 
1) Uses vec![] for the OpaqueKeyProof as there's no value to passing it around
2) Remove usage of Babe/Grandpa Offences for tracking if an offence is known
   for checking if can slash. If can slash, no prior offence must have been
   known.
3) Rename DisabledIndices to SeraiDisabledIndices, drop historical data for
   current session only.
4) Doesn't remove from the pre-declared upcoming Serai set upon slash due to
   breaking light clients.
5) Into/From instead of AsRef for KeyOwnerProofSystem's generic to ensure
   safety of the conversion.
@kayabaNerve
Correct deduction from TotalAllocatedStake on slash
b2495b8 
It should only be done if in set and only with allocations contributing to
TotalAllocatedStake (Allocation + latest session's PendingDeallocation).
@kayabaNerve
Changes meant for prior commit
ec935e3
@kayabaNerve kayabaNerve merged commit c40ce00 into serai-dex:develop Dec 16, 2023
10 checks passed
@kayabaNerve kayabaNerve added feature New feature or request runtime labels Dec 16, 2023
@akildemir akildemir deleted the slashing branch January 2, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayabaNerve kayabaNerve kayabaNerve requested changes

Assignees
No one assigned
Labels
feature New feature or request runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akildemir @kayabaNerve