Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt layout output to upstream version #4

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Adapt layout output to upstream version #4

merged 1 commit into from
Feb 20, 2024

Conversation

der-eismann
Copy link
Contributor

No description provided.

livingsilver94
livingsilver94 requested changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@livingsilver94 livingsilver94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL as a source is totally fine, but I'd rather see a brief explanation in plain English as well. Something unpretentious like:

Replicate the output of moss (that acts like the reference implementation for us).

@der-eismann der-eismann force-pushed the adapt-layout-output-to-upstream branch from 8ec8b39 to a935fa1 Compare February 20, 2024 15:50
@der-eismann
Copy link
Contributor Author

Good point!

@livingsilver94
Copy link
Collaborator

I don't want to nitpick this time, but please end sentences in comments with a dot in the future, please :)

@der-eismann der-eismann force-pushed the adapt-layout-output-to-upstream branch from a935fa1 to 7937678 Compare February 20, 2024 19:14
@der-eismann der-eismann merged commit fe8aacd into main Feb 20, 2024
2 checks passed
@der-eismann der-eismann deleted the adapt-layout-output-to-upstream branch February 20, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@livingsilver94 livingsilver94 livingsilver94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@der-eismann @livingsilver94