Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boulder: Add support for compressman option #281

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joebonrichie
Copy link
Contributor

Compresses any man/info pages with zstd. A tradeoff between slightly bigger .stone files vs smaller installed size.

Tested

  • nano (contains man and info files)
  • xz (contains lots of man symlinks)

@joebonrichie joebonrichie force-pushed the boulder-compressman branch from 237ee8f to 31c3fbc Compare July 18, 2024 00:17
Copy link
Contributor

@livingsilver94 livingsilver94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm not a Rust expert, let's try to make this code more idiomatic by using the Path/PathBuf structs.

boulder/src/package/analysis/handler.rs Outdated Show resolved Hide resolved
boulder/src/package/analysis/handler.rs Outdated Show resolved Hide resolved
boulder/src/package/analysis/handler.rs Outdated Show resolved Hide resolved
@joebonrichie joebonrichie force-pushed the boulder-compressman branch 3 times, most recently from 854052f to 4edb90e Compare July 21, 2024 16:07
@joebonrichie joebonrichie marked this pull request as ready for review July 21, 2024 16:09
@joebonrichie joebonrichie force-pushed the boulder-compressman branch from 4edb90e to ebcb9ef Compare July 21, 2024 16:11
@joebonrichie joebonrichie force-pushed the boulder-compressman branch 2 times, most recently from f29c2d7 to 57e42cf Compare August 19, 2024 12:24
@joebonrichie
Copy link
Contributor Author

Should be good now

@joebonrichie joebonrichie force-pushed the boulder-compressman branch 2 times, most recently from db2203f to 8f4fedf Compare September 12, 2024 20:17
@joebonrichie
Copy link
Contributor Author

🏓

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants