Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devcontainer] Fix mount and GPU & Support rust dev #2978

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Conversation

ByronHsu
Copy link
Collaborator

Motivation

  1. The current workspaceFolder in dev container is wrong. We should just remove it and use the default setting.

Reason: The local workspace is mounted to /workspace/sglang but vscode will open /sgl-workspace/sglang/, which is actually the pre-installed sglang from the base image instead of the local one/

  1. Install uv for faster dev installation and rust for rust development

  2. Add --gpus=all for the container to access GPUs

Modifications

Checklist

@ByronHsu ByronHsu requested a review from zhyncs January 19, 2025 08:24
@ByronHsu
Copy link
Collaborator Author

cc @zhyncs

@zhyncs
Copy link
Member

zhyncs commented Jan 19, 2025

@ByronHsu ByronHsu changed the title Fix vscode devcontainer setup [devcontainer] Fix mount and GPU & Support rust dev Jan 19, 2025
@zhyncs zhyncs merged commit 53cc91e into main Jan 19, 2025
3 of 4 checks passed
@zhyncs zhyncs deleted the byhsu/devcontainer branch January 19, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants