Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add activation parameters to fused_moe #3170

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Add activation parameters to fused_moe #3170

merged 3 commits into from
Jan 27, 2025

Conversation

merrymercy
Copy link
Contributor

This is because grok uses gelu while other models use silu.

HaiShaw
HaiShaw approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@HaiShaw HaiShaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@merrymercy merrymercy merged commit 52c03f1 into main Jan 27, 2025
12 of 17 checks passed
@merrymercy merrymercy deleted the fix-act-moe branch January 27, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaiShaw HaiShaw HaiShaw approved these changes

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@ByronHsu ByronHsu Awaiting requested review from ByronHsu ByronHsu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merrymercy @HaiShaw