Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kernel] Fix position ids in rope #3173

Merged
merged 4 commits into from
Jan 27, 2025
Merged

[kernel] Fix position ids in rope #3173

merged 4 commits into from
Jan 27, 2025

Conversation

ByronHsu
Copy link
Collaborator

Motivation

There was an error. Not sure why the CI did not catch it.

Modifications

Checklist

@ByronHsu ByronHsu marked this pull request as ready for review January 27, 2025 08:58
@ByronHsu ByronHsu mentioned this pull request Jan 27, 2025
4 tasks
@ByronHsu
Copy link
Collaborator Author

I see why. The command to run rope test should be pytest ... but we were using python ...

@zhyncs zhyncs merged commit 514f37c into main Jan 27, 2025
4 of 5 checks passed
@zhyncs zhyncs deleted the byhsu/fix-rope branch January 27, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants