[test] Lower number of top logprobs to get rid of -inf
#3212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
One of the latest CI failed (
test_srt_endpoint_with_penalizers.py
) https://github.com/sgl-project/sglang/actions/runs/13006304270/job/36334676037.This is a known issue #2955. In short, if the returned logprob contains
-inf
, fastapi will crash because it cannot handle-inf
by default (fastapi/fastapi#8912).The latest rope implementation makes the distribution more spiky likely due to the higher precision (now rope uses fp32, but before was bf16). The correctness is guaranteed as all other tests have passed.
The temporary solution is to lower top_logprobs_num because if the number is large, it is more likely the latter probs will be
-inf
, especially with penalty. e.gThis PR is to fix the CI. In the meantime, I will see if i can add a threshold for the logit processor or make fastapi able to handle
-inf
Modifications
Checklist