-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main fix streaming #3239
Closed
Closed
Merge main fix streaming #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shortfin backend
Add examples for fork and batch, Update max_tokens to max_completion_tokens
Enable bench_serving benchmark for SGLang + Add `fork` and `batch` to Example Script
Shortfin support
…rtfin backend streaming
stbaione
requested review from
zhyncs,
ispobock,
HandH1998,
BBuf,
yizhang2077,
merrymercy,
ByronHsu,
Ying1123,
hnyls2002 and
HaiShaw
as code owners
January 31, 2025 18:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Merges main from origin repo, and has a fix for the shortfin backend after I changed the way that it streams