govstaking/src/GovernanceStaker.sol #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CergyK
reviewed
Nov 28, 2024
CergyK
reviewed
Nov 28, 2024
CergyK
reviewed
Nov 28, 2024
CergyK
reviewed
Nov 28, 2024
CergyK
reviewed
Nov 29, 2024
| pragma solidity ^0.8.23; | ||
|
|
||
| import {DelegationSurrogate} from "src/DelegationSurrogate.sol"; | ||
| import {DelegationSurrogateVotes} from "src/DelegationSurrogateVotes.sol"; |
CergyK
reviewed
Nov 30, 2024
CergyK
reviewed
Nov 30, 2024
CergyK
reviewed
Nov 30, 2024
jokrsec
reviewed
Dec 3, 2024
jokrsec
reviewed
Dec 6, 2024
| /// @param _depositId The identifier for the deposit that needs an updated earning power. | ||
| /// @param _tipReceiver The receiver of the reward for updating a deposit's earning power. | ||
| /// @param _requestedTip The amount of tip requested by the third-party. | ||
| function bumpEarningPower( |
There was a problem hiding this comment.
If user claims complete unclaimed rewards from a deposit whose earning power is zero, bumping would not be possible from later even if delegatee becomes eligible
CergyK
reviewed
Dec 7, 2024
| /// @notice Set the earning power calculator address. | ||
| function setEarningPowerCalculator(address _newEarningPowerCalculator) external virtual { | ||
| _revertIfNotAdmin(); | ||
| _setEarningPowerCalculator(_newEarningPowerCalculator); |
There was a problem hiding this comment.
Would probably make sense to check that no reward distribution is pending, or ensure that calculator state is initialized with same state as the previous one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
govstaking/src/GovernanceStaker.sol