Fix Review #1
Open
Fix Review #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlock-admin
commented
Feb 28, 2025
Comment on lines
+140
to
+142
| try | ||
| aWETH.permit(msg.sender, address(this), amount, deadline, permitV, permitR, permitS) | ||
| {} catch {} |
There was a problem hiding this comment.
Change related to bgd-labs/aave-v3-origin#50.
Fixes issues: #209
sherlock-admin
commented
Feb 28, 2025
Comment on lines
+230
to
+268
| function test_withdrawEth_permit_frontrunRegression() public { | ||
| test_depositNativeEthInPool(); | ||
|
|
||
| uint256 withdrawAmount = 0.6e18; | ||
|
|
||
| EIP712SigUtils.Permit memory permit = EIP712SigUtils.Permit({ | ||
| owner: alice, | ||
| spender: address(wrappedTokenGatewayV3), | ||
| value: withdrawAmount, | ||
| nonce: 0, | ||
| deadline: block.timestamp + 1 days | ||
| }); | ||
| bytes32 digest = EIP712SigUtils.getTypedDataHash( | ||
| permit, | ||
| bytes(aWEth.name()), | ||
| bytes('1'), | ||
| address(aWEth) | ||
| ); | ||
|
|
||
| (uint8 v, bytes32 r, bytes32 s) = vm.sign(alicePrivateKey, digest); | ||
|
|
||
| uint256 userEthBalanceBefore = alice.balance; | ||
|
|
||
| vm.prank(alice); | ||
| aWEth.permit(permit.owner, permit.spender, permit.value, permit.deadline, v, r, s); | ||
|
|
||
| // should not revert if permit is already executed | ||
| vm.prank(alice); | ||
| wrappedTokenGatewayV3.withdrawETHWithPermit( | ||
| report.poolProxy, | ||
| withdrawAmount, | ||
| alice, | ||
| permit.deadline, | ||
| v, | ||
| r, | ||
| s | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Change related to bgd-labs/aave-v3-origin#50.
Fixes issues: #209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Review of
Repo:
bgd-labs/aave-v3-originCommit Hash:
21c30148d1484ddec57f5d223f530179b103cae6