[WIP]チームT #1
Open
[WIP]チームT #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanaka-yoshi10
commented
Feb 4, 2017
README.md~
Outdated
| @@ -0,0 +1 @@ | |||
| Readme | |||
tanaka-yoshi10
commented
Feb 4, 2017
cart.rb
Outdated
|
|
||
|
|
||
| def fee | ||
| sum = 0 |
There was a problem hiding this comment.
injectで短くできそう
tanaka-yoshi10
commented
Feb 4, 2017
lib/tregi/item.rb
Outdated
| @@ -0,0 +1,9 @@ | |||
| class Item | |||
tanaka-yoshi10
commented
Feb 4, 2017
lib/tregi/order.rb
Outdated
| class Order | ||
| item | ||
| amount | ||
| end |
There was a problem hiding this comment.
これは使わないなら消すかな？
murajun1978
reviewed
Feb 4, 2017
lib/tregi/item.rb
Outdated
| attr_accessor :name | ||
| attr_accessor :price | ||
|
|
||
| def initialize(name, price) |
There was a problem hiding this comment.
initializeのparamsはhashがbestだと思う
理由は並び順に依存しないからです。
tanaka-yoshi10
commented
Feb 4, 2017
| item | ||
| amount | ||
| end | ||
| end |
tanaka-yoshi10
commented
Feb 4, 2017
| @cart.fee | ||
| end | ||
|
|
||
| def purchase(fee) |
There was a problem hiding this comment.
カートに入っている合計価格 (self.fee)と 払われたお金(fee)は
違う名前にしたほうがわかりやすいかも
tanaka-yoshi10
commented
Feb 4, 2017
| attr_accessor :name | ||
| attr_accessor :price | ||
|
|
||
| #def initialize(name, price) |
tanaka-yoshi10
commented
Feb 4, 2017
| attr_accessor :price | ||
|
|
||
| #def initialize(name, price) | ||
| def initialize(params) |
There was a problem hiding this comment.
def initialize(params=={})
としたほうが良い？
tanaka-yoshi10
commented
Feb 4, 2017
| class Register | ||
| attr_reader :surplus | ||
|
|
||
| def initialize(cart) |
There was a problem hiding this comment.
カートをあとで変えれない？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.