Skip to content

Commit

Permalink
feat(backburner): add support for garbage limit
Browse files Browse the repository at this point in the history
  • Loading branch information
thomaslishopline committed Jan 24, 2025
1 parent 6b64ec1 commit 4f972f9
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion backburner/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v1
description: Helm chart for ruby backburner workers
name: backburner
version: 0.6.0
version: 0.7.0
appVersion: 0.0.1
7 changes: 4 additions & 3 deletions backburner/templates/_container.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
{{- range $i, $items := .queue }}
{{- $queueName := get $items "queueName" }}
{{- $listener := get $items "listener" | int }}
{{- $garbage := get $items "garbage" | default "" }}
{{- if (default $standAlone false ) }}
{{- if gt $listener 1 }}
{{ fail "listener more than one failed when the standalone mode."}}
Expand All @@ -33,11 +34,11 @@
{{- $listener = 2 }}
{{- end}}
{{- end}}
{{- $tmpItem := printf "%v:%v" $queueName $listener }}
{{- $tmpItem := printf "%v:%v:%v" $queueName $listener $garbage }}
{{- $queueList = append $queueList $tmpItem }}
{{- end }}
{{- $queueName := (join "," $queueList) }}
- bundle exec backburner -e $RAILS_ENV -q {{ $queueName }}
{{- $queueName := printf "\"%s\"" (join "," $queueList) }}
- QUEUE={{ $queueName }} RAILS_ENV=$RAILS_ENV bundle exec rake backburner:threads_on_fork:work
{{- end }}
image: "{{ .image.repository }}:{{ .image.tag }}"
imagePullPolicy: "IfNotPresent"
Expand Down
9 changes: 5 additions & 4 deletions backburner/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ workers: []
# queue:
# - queueName: custom-jobs
# listener: 2
# garbage: 100 # Number of job executions before garbage collection, note that this only works on ThreadsOnFork worker
# resources:
# limits:
# cpu: "300m"
Expand All @@ -56,8 +57,8 @@ workers: []
# percent: 70
# - name: worker1
# queue:
# - queueName: user-import-notification0 # default listener: 2
# - queueName: user-import-notification1 # default listener: 2
# - queueName: user-import-notification0 # default listener: 2, default garbage: ""
# - queueName: user-import-notification1 # default listener: 2, default garbage: ""
# resources:
# limits:
# cpu: "2"
Expand All @@ -67,8 +68,8 @@ workers: []
# memory: "4Gi"
# - name: worker2
# queue:
# - queueName: user-import-notification0 # default listener: 2
# - queueName: user-import-notification1 # default listener: 2
# - queueName: user-import-notification0 # default listener: 2, default garbage: ""
# - queueName: user-import-notification1 # default listener: 2, default garbage: ""
# resources:
# limits:
# cpu: "2"
Expand Down

0 comments on commit 4f972f9

Please sign in to comment.