Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added to allow for two mod sources, mod0 and mod1 #267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koltenpearson
Copy link

For the project I am working on I wanted the ability to have 2 LFOs so I went ahead and added support for it.

If this is not desired then no worries, go ahead and close it.

If this is desired then note I only made the minimal number of changes to support my use case. Specifically I did not try to support python, and I imagine it breaks the examples and tests. I figured I would wait and see if this was wanted before going any farther.

I am willing to add support to the python bindings examples and tests, though I will probably need a little guidance on how you would want the syntax and argument names to be in the interest of backwards compatibility and whatnot.

@bwhitman
Copy link
Collaborator

bwhitman commented Jan 7, 2025

Nice! We'll take a look.

@dpwe
Copy link
Collaborator

dpwe commented Jan 7, 2025

Nice work.

I am curious about the 2 LFO use case - is it for pitch and envelope at separate rates or something like that?

@koltenpearson
Copy link
Author

Yes being able to change both pitch and amplitude/pwm on the same oscillator is the use case I had in mind. It is more for me to experiment with than achieve a specific sound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants