Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Data Creation #2

Merged
merged 18 commits into from
Feb 5, 2025
Merged

PR: Data Creation #2

merged 18 commits into from
Feb 5, 2025

Conversation

RongLirr
Copy link
Collaborator

No description provided.

@RongLirr
Copy link
Collaborator Author

example_poses.zip

The file contains two pairs of pose examples, along with a processing.log for additional details.

AmitMY
AmitMY requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@AmitMY AmitMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty good! minor changes requested, then you can go ahead and generate the data for the entire dataset

fluent_pose_synthesis/data/map_gloss_to_pose.py Outdated Show resolved Hide resolved
fluent_pose_synthesis/data/map_gloss_to_pose.py Outdated Show resolved Hide resolved
fluent_pose_synthesis/data/map_gloss_to_pose.py Outdated Show resolved Hide resolved
fluent_pose_synthesis/data/create_data.py Show resolved Hide resolved
AmitMY
AmitMY approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@AmitMY AmitMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can always iterate later if there are issues :)

AmitMY
AmitMY reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@AmitMY AmitMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pylint fails.

fluent_pose_synthesis/create_stitched_example.py:4:0: E0401: Unable to import 'spoken_to_signed.gloss_to_pose' (import-error)

add that dependency to the pyproject.toml

@RongLirr RongLirr merged commit c686e2b into sign-language-processing:main Feb 5, 2025
1 of 2 checks passed
@RongLirr RongLirr deleted the question/code-draft branch February 5, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmitMY AmitMY AmitMY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RongLirr @AmitMY