Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pose copy and remove components #148

Merged
merged 18 commits into from
Feb 4, 2025
Merged

Feature/pose copy and remove components #148

merged 18 commits into from
Feb 4, 2025

Conversation

cleong110
Copy link
Contributor

Fixes #147

cleong110 and others added 12 commits March 8, 2024 11:42
@cleong110 cleong110 mentioned this pull request Jan 28, 2025
Open
AmitMY
AmitMY requested changes Jan 28, 2025
View reviewed changes
src/python/pose_format/pose.py Outdated Show resolved Hide resolved
src/python/pose_format/pose.py Show resolved Hide resolved
@cleong110
Copy link
Contributor Author

Added .copy() methods to various PoseBody implementations, and some pytests for this.

cleong110 added a commit to cleong110/pose-evaluation that referenced this pull request Jan 30, 2025
@cleong110
remove copy_pose in favor of pose.copy() from sign-language-processin…
aecafa5 
…g/pose#148
cleong110 added a commit to cleong110/pose-evaluation that referenced this pull request Jan 30, 2025
@cleong110
replace remove_components with new one from sign-language-processing/…
3197ff8 
…pose#148
AmitMY
AmitMY requested changes Jan 31, 2025
View reviewed changes
src/python/pose_format/numpy/pose_body.py Outdated Show resolved Hide resolved
src/python/pose_format/numpy/pose_body.py Outdated Show resolved Hide resolved
src/python/pose_format/tensorflow/pose_body.py Outdated Show resolved Hide resolved
src/python/pose_format/torch/pose_body.py Outdated Show resolved Hide resolved
src/python/tests/pose_test.py Outdated Show resolved Hide resolved
src/python/tests/pose_test.py Outdated Show resolved Hide resolved
AmitMY
AmitMY approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@AmitMY AmitMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for one import. does it matter?

src/python/pose_format/numpy/pose_body.py Show resolved Hide resolved
src/python/tests/pose_test.py Outdated Show resolved Hide resolved
@AmitMY AmitMY merged commit f85bfb9 into sign-language-processing:master Feb 4, 2025
8 checks passed
@cleong110 cleong110 mentioned this pull request Feb 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmitMY AmitMY AmitMY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pose: add .copy() and .remove_components()
2 participants
@cleong110 @AmitMY