-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example with more math formulas #46
Conversation
a2a14bb
to
600bccb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and yes this should be all there is too it to add an example to the website.
@@ -145,6 +145,11 @@ fn = "math" | |||
source = "math.sil" | |||
title = "Math" | |||
|
|||
[[packages]] | |||
fn = "math-formulas" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fn = "math-formulas" | |
fn = "math-formulas" | |
devel = true |
I don't know if you need this change, but if you even need an example to build with the current default development branch (currently master) then you can add this flag.
$ nix-shell --run 'sile --version'
SILE v0.15.7 (LuaJIT 2.1.1713773202) [Rust]
Ergo if you need anything in v0.15.8 or later, add this flag. Otherwise it will build the example with v0.15.7.
I think the CI failure is unrelated to this PR. I'll look into it. |
CI failure is because we broke the Lua API documentation build in v0.15.7 (which is why that version's blog post never went online). This CI failure is just a cascade of that failure. |
Not sure it's related, but I've noted (my bad) some typing errors in the CSL support. 'Was about to go for a fix. |
Closes #45
Fixed the SIL file from my earlier ZIP provided in the issue, and proposed here -- I don't know if this is the right way to proceed.