Separate confident and imprecise detectors, introduce detector identification #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
force-pushed
the
add-detector-id
branch
from
4047234 to
793ef33
Compare
Extend the `Detector` type with an `id` property, which allows users to understand which detector is doing what. The core detectors are seperated in: Extend the `Detector` type with an `id` property, which allows users to understand which detector is doing what. The core detectors are seperated in: - `default.safe`: Safe core detectors - `default.unsafe`: Collection of detectors with higher probability of false positive
Borewit
force-pushed
the
add-detector-id
branch
from
793ef33 to
4b2a511
Compare
|
Is "unsafe" the right word? It makes it sound like they have vulnerabilities, which is not correct. Maybe: unreliable, unstable, imprecise, fragile |
|
Loose, lax, speculative, unreliable, weak, sparse, indistinct? |
|
Lets go with |
sindresorhus
reviewed
Jan 5, 2025
- Confident (`core`): Represents detections with a high degree of certainty in identifying the correct file type. - Imprecise (`core.imprecise`): Represents detections with limited supporting data, resulting in a higher likelihood of false positives.
Borewit
force-pushed
the
add-detector-id
branch
from
39af320 to
1c66e0a
Compare
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the
Detectortype with anidproperty, which allows users to understand which detector is doing what. The core detectors are seperated in:default.safe: Safe core detectorsdefault.unsafe: Collection of detectors with higher probability of false positiveResolves: #483