Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Java archive (.jar) #719

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

sly7-7
Copy link
Contributor

@sly7-7 sly7-7 commented Jan 8, 2025

Add support based on the presence of the META_INF/MANIFEST.mf file.

@sly7-7
Copy link
Contributor Author

sly7-7 commented Jan 8, 2025

The fail in node 20 is unrelated to the code (error during npm install)

@Borewit Borewit added the enhancement Add new functionality label Jan 9, 2025
@Borewit
Copy link
Collaborator

Borewit commented Jan 9, 2025

Please rebase @sly7-7

@sly7-7 sly7-7 force-pushed the jar-archive-support branch from 004bbe7 to ead34b5 Compare January 10, 2025 07:29
@sly7-7
Copy link
Contributor Author

sly7-7 commented Jan 10, 2025

@Borewit done

Copy link
Collaborator

@Borewit Borewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sindresorhus sindresorhus merged commit 8651809 into sindresorhus:main Jan 10, 2025
3 checks passed
@sly7-7 sly7-7 deleted the jar-archive-support branch January 10, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants