Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate the goroutine on shutdown #17

Merged
merged 1 commit into from
May 28, 2024
Merged

Terminate the goroutine on shutdown #17

merged 1 commit into from
May 28, 2024

Conversation

braams
Copy link
Contributor

@braams braams commented May 28, 2024

This goroutine could not terminate. This led to resource leakage. Now it will be terminated when Shutdown is called.

@sobomax
Copy link
Member

sobomax commented May 28, 2024

@braams looks good, 👍would be nice to have a unit test case though! 🤔

@sobomax sobomax merged commit c650a08 into sippy:master May 28, 2024
1 check passed
@sobomax
Copy link
Member

sobomax commented May 28, 2024

@braams thanks, merged. I've added UT to verify number of goroutines before and after shutdown. See

go-b2bua/sippy/stm_test.go

Line 34 in 13327d8

t.Fatalf("numGoroutinesBefore = %d, numGoroutinesAfter = %d\n", numGoroutinesBefore, numGoroutinesAfter)

@braams
Copy link
Contributor Author

braams commented May 28, 2024

Great! Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braams @sobomax