Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip 14 pixel at the bottom of mobile tests. #2225

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Skip 14 pixel at the bottom of mobile tests. #2225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11cd9b6
Skip 14 pixel at the bottom of mobile tests.
soulgalore Dec 19, 2024
b6a01a6
Merge branch 'main' into offset
soulgalore Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion visualmetrics/visualmetrics-portable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ def find_image_viewport(file, is_mobile):
# On mobile we need to ignore the top ~10 pixels because
# there is a visible progress bar there on some browsers.
viewport["y"] += 10
viewport["height"] -= 10
viewport["height"] -= 14

except Exception:
viewport = None
Expand Down
Loading