Skip to content

Commit

Permalink
New bt and display more settings (#4414)
Browse files Browse the repository at this point in the history
* New bt and display more settings

* fix
  • Loading branch information
soulgalore authored Jan 27, 2025
1 parent 0367ab4 commit 4ca89b0
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 14 deletions.
12 changes: 11 additions & 1 deletion lib/plugins/html/htmlBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,12 +217,22 @@ export class HTMLBuilder {
// In the future we can fix so we just pickup the setup messages
usingBrowsertime = pageInfo.data.browsertime;
// if we don't use Browsertime, we don't get the browser version

browser = usingBrowsertime
? {
name: pageInfo.data.browsertime.pageSummary.info.browser.name,
version: pageInfo.data.browsertime.pageSummary.info.browser.version,
userAgent:
pageInfo.data.browsertime.pageSummary.info.browser.userAgent
pageInfo.data.browsertime.pageSummary.info.browser.userAgent,
args: pageInfo.data.browsertime.pageSummary.info.browser.args,
traceCategories:
pageInfo.data.browsertime.pageSummary.info.browser
.traceCategories,
preference:
pageInfo.data.browsertime.pageSummary.info.browser.preference,
geckoProfilerFeatures:
pageInfo.data.browsertime.pageSummary.info.browser
.geckProfilerFeatures
}
: {
name: '',
Expand Down
16 changes: 16 additions & 0 deletions lib/plugins/html/templates/settings.pug
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,22 @@ block content
tr
td Number of runs
td #{get(options, 'browsertime.iterations')}
if get(browser, 'traceCategories') !== undefined
tr
td Trace categories
td #{get(browser, 'traceCategories')}
if get(browser, 'preference') !== undefined
tr
td browser.preference
td #{get(browser, 'preference')}
if get(browser, 'args') !== undefined
tr
td browser.args
td #{get(browser, 'args')}
if get(browser, 'geckoProfilerFeatures') !== undefined
tr
td Gecko Profiler Features
td #{get(browser, 'geckoProfilerFeatures')}
tr
td OS
td #{android ? 'Android' : (ios ? 'iOS' : (options.browsertime.docker ? 'Docker using ' + os: os)) }
Expand Down
24 changes: 12 additions & 12 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"@tgwf/co2": "0.16.4",
"@slack/webhook": "7.0.4",
"axe-core": "4.10.2",
"browsertime": "24.0.1",
"browsertime": "24.1.0",
"coach-core": "8.1.1",
"dayjs": "1.11.11",
"fast-crc32c": "2.0.0",
Expand Down

0 comments on commit 4ca89b0

Please sign in to comment.