Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom factory namer #67

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anjeshshrestha
Copy link
Contributor

adding a custom factory name in config file instead of the auto generated one

@terminalsin
Copy link
Member

I’m going to have to decline this one. The reason why is if you have two jars with the same factory, they conflict and one does not load properly.

@anjeshshrestha
Copy link
Contributor Author

anjeshshrestha commented Nov 24, 2024

the default would still be auto generated, the dev can configure to use custom name and nested folder
ex. "com/pikapika/obf" would generate the factory in the correct file path.

I'm having the issue with windows defender and other virus scanners flagging the plugin with the auto generated folder/path and class name and blocking or deleting the jar

CleanShot 2024-11-23 at 18 28 11@2x

we can rework it so it would generate a root path if not provided one
ex. "factory" would be "<random_uuid>/factory.class"
but "com/factory" would be "com/factory.class"

@terminalsin
Copy link
Member

I see. Let me add a randomised english word generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants