Fix typos #7337
Open
Fix typos #7337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran `typos .` and fixed all typos that do make sense. https://crates.io/crates/typos
tronical
approved these changes
Jan 12, 2025
| @@ -2172,7 +2172,7 @@ extern "C" fn supported_accessibility_actions( | |||
| .accessibility_props | |||
| .0 | |||
| .keys() | |||
| .filter_map(|x| x.strip_prefix("acessible-action-")) | |||
| .filter_map(|x| x.strip_prefix("accessible-action-")) | |||
There was a problem hiding this comment.
This one makes me shake my head - how did this work before?
There was a problem hiding this comment.
I thought there would be the counter-part but haven't found it.
There was a problem hiding this comment.
Yeah I think your change is entirely correct. This probably never worked before....
There was a problem hiding this comment.
When I test accessible actions, I use the accessibility inspector, which requires an app bundle. So I always end up compiling rust code, instead of using the interpreter. But evidently we're missing automated test coverage.
There was a problem hiding this comment.
Thanks for the confirmation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
typos .and fixed all typos that do make sense.https://crates.io/crates/typos