Use jemalloc for slint-viewer and slint-compiler #7340
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lots of allocations are slowing down slint-viewer. By using the faster jemalloc, we get a significant time boost on Linux at least, where I can observe a 15% time reduction: Before: ``` Time (mean ± σ): 936.6 ms ± 13.5 ms [User: 688.8 ms, System: 191.1 ms] Range (min … max): 918.9 ms … 955.6 ms 10 runs ``` After: ``` Time (mean ± σ): 794.8 ms ± 16.2 ms [User: 645.4 ms, System: 99.2 ms] Range (min … max): 755.0 ms … 810.7 ms 10 runs ```
As with the slint-viewer, we can observe a drastic time improvement of around 13% when using jemalloc for slint-compiler: Before: ``` Time (mean ± σ): 772.8 ms ± 9.2 ms [User: 633.5 ms, System: 136.5 ms] Range (min … max): 763.3 ms … 787.8 ms 10 runs ``` After: ``` Time (mean ± σ): 672.5 ms ± 13.5 ms [User: 610.4 ms, System: 60.1 ms] Range (min … max): 655.1 ms … 700.7 ms 10 runs ```
|
Nice. We should do the same for slint-lsp, I guess. |
|
Why not with msvc? |
|
Nice! I think this should use the successor perhaps? https://crates.io/crates/tikv-jemallocator |
|
(This also affects cross-compilation with Yocto for C++, I'd like to run the Yocto build test before merging this) |
The official docs does it this way 🤷 https://github.com/gnzlbg/jemallocator?tab=readme-ov-file#documentation
Uff I'll have to research why there are both and what the differences are but yes if that one is newer and officially endorsed then let's use that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives us a ~15% speed improvement basically for free (minimal code changes)