feat: Terminate dns name of default loginUrl

[jokajak]

This changeset sets the bitwarden-eso-provider.clusterSecretStore.loginUrl to be terminated with a . so that the search domain is not appended to the hostname ideally forcing it to resolve within the cluster.

[jessebot]

Could you please bump the helm chart version here by one patch version (so 0.5.1):

bitwarden-eso-provider/charts/bitwarden-eso-provider/Chart.yaml

Line 18 in a82e5a5

version: 0.5.0

This way, when the change is merged, it will push out a new release of the helm chart :)

Have you tested this locally?

Also, tagged @cloudymax for review as they work on this code base more than me.

[cloudymax]

Looks like it works to me

Current method:

$ kubectl exec -i -t dnsutils -- nslookup bitwarden-eso-provider.external-secrets.svc.cluster.local
Server:         10.43.0.10
Address:        10.43.0.10#53

Name:   bitwarden-eso-provider.external-secrets.svc.cluster.local
Address: 10.43.228.224

New method:

$ kubectl exec -i -t dnsutils -- nslookup bitwarden-eso-provider.external-secrets.svc.cluster.local.
Server:         10.43.0.10
Address:        10.43.0.10#53

Name:   bitwarden-eso-provider.external-secrets.svc.cluster.local
Address: 10.43.228.224

After the chart is bumped we can get this merged 👍

[jessebot]

Looks good! Thank you for your contribution!