[Infoplat-1563] Validate protobuf schema evolution compatibility using schema registry #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anukin
commented
Jan 20, 2025
erikburt
reviewed
Jan 21, 2025
erikburt
requested changes
Jan 28, 2025
anukin
commented
Jan 28, 2025
| shell: bash | ||
| run: | | ||
| docker compose up -d redpanda-console | ||
| - name: Configure aws creds |
There was a problem hiding this comment.
@erikburt I would love to have your review here. I am not that familiar with this. Will this approach to pulling images work in other repos where these actions would be used?
Are there some changes/alternatives I should explore?
There was a problem hiding this comment.
Yes this should work.
The callers of this action will need to pass an AWS role they can assume, and that role requires read-access to the ECR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds a new action which integrates beholder validator for schema changes
Why?
This is needed so that beholder validator can be integrated with the schema changes given a beholder.yaml is present in the repo.