[INFOPLAT-1427] Action to deploy Protobuf/AVRO schemas to Confluent Schema Registry #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriosNaikopoulos
requested changes
Feb 3, 2025
| aws_account_id: | ||
| description: "AWS Account ID" | ||
| required: false | ||
| default: "654654554896" # this is info platform sandbox. TBD: change to prod account once ready |
There was a problem hiding this comment.
Should this change to prod account or the PR is not yet ready? (because is marked as open and not Draft)
There was a problem hiding this comment.
will change soon, but thanks for flagging.
There was a problem hiding this comment.
update: we'll leave the sandbox account default to start off (since this is just an MVP), and clients may use the prod one if they so wish.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket for details.