Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Solana] Refactor token pool for readability #519

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Solana] Refactor token pool for readability #519

wants to merge 1 commit into from
+504 −337

Conversation

PabloMansanet
Copy link
Contributor

@PabloMansanet PabloMansanet commented Jan 29, 2025 •
edited
Loading

EDIT: Setting to draft as I'm de-prioritizing this work for now.

Readability pass for the token pool contract + context.

  • Normalized comment style.
  • Removed comments that duplicated what was evident in the code + variable names.
  • Added some comments.
  • Broke down large functions into components to make them easier to parse.
  • Scoped some objects into modules.

@PabloMansanet PabloMansanet requested a review from a team as a code owner January 29, 2025 16:51
@github-actions GitHub Actions
Copy link

Metric readability_pass_token_pool main
Coverage 76.7% 76.6%

@PabloMansanet PabloMansanet marked this pull request as draft January 29, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PabloMansanet