Use GetSourceChainConfig instead of OffRampGetAllSourceChainConfigs #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reductionista
force-pushed
the
domino/get_all_chain_configs
branch
from
47b91ad to
f85fc49
Compare
reductionista
changed the title
reductionista
force-pushed
the
domino/get_all_chain_configs
branch
8 times, most recently
from
70b1616 to
7aed7b5
Compare
reductionista
force-pushed
the
domino/get_all_chain_configs
branch
from
7aed7b5 to
3113af7
Compare
reductionista
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
prashantkumar1982
approved these changes
Feb 6, 2025
winder
reviewed
Feb 6, 2025
Comment on lines
+1180
to
+1182
| results, _, err := r.contractReaders[r.destChain].ExtendedBatchGetLatestValues( | ||
| ctx, contractreader.ExtendedBatchGetLatestValuesRequest{consts.ContractNameOffRamp: contractBatch}, | ||
| false, |
There was a problem hiding this comment.
Previously this was using an Unconfirmed confidence level. What level is used with batch get?
There was a problem hiding this comment.
It's ignored anyway on Solana. Looks like it does default to Unconfirmed on EVM, and the possibility of overriding the default looks mostly implemented. Not sure why they didn't expose that feature in the API:
https://github.com/smartcontractkit/chainlink/blob/develop/core/services/relay/evm/read/batch.go#L132-L140
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't any efficient way to implement OffRampGetAllSourceChainConfigs on Solana, due to the information being spread across many different Accounts while not having the seeds passed as input params to determine the PDA's for those accounts. GetSourceChainConfig works on both evm & solana
Note:
We could do it using getProgramAccounts, but this requires account indexing to be enabled on the rpc server, doubling memory requirements to run it. We could also get around it by storing a list of the PDA's in an account with a fixed prefix, but this would require us to have a maximum limit on the number of chains we support. If the maximum limit was too high, it would waste costly on-chain storage space without actually using it. Too low, and we'd have to update the smart contracts when we hit the limit.