WIP revert custom compute ID

smartcontractkit · Feb 7, 2025 · a119cf3 · a119cf3
1 parent 8f50d72
commit a119cf3
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 30 deletions.
diff --git a/pkg/workflows/sdk/builder_test.go b/pkg/workflows/sdk/builder_test.go
@@ -382,7 +382,7 @@ func TestBuilder_ValidSpec(t *testing.T) {
 			},
 			Actions: []sdk.StepDefinition{
 				{
-					ID:  "custom-compute@1.0.0",
+					ID:  "custom_compute@1.0.0",
 					Ref: "compute",
 					Inputs: sdk.StepInputs{
 						Mapping: map[string]any{"Arg0": "$(trigger.outputs.cool_output)"},
@@ -394,7 +394,7 @@ func TestBuilder_ValidSpec(t *testing.T) {
 					CapabilityType: capabilities.CapabilityTypeAction,
 				},
 				{
-					ID:  "custom-compute@1.0.0",
+					ID:  "custom_compute@1.0.0",
 					Ref: "compute again",
 					Inputs: sdk.StepInputs{
 						Mapping: map[string]any{"Arg0": "$(trigger.outputs.cool_output.0)"},
@@ -437,7 +437,7 @@ func TestBuilder_ValidSpec(t *testing.T) {
 			},
 			Actions: []sdk.StepDefinition{
 				{
-					ID:  "custom-compute@1.0.0",
+					ID:  "custom_compute@1.0.0",
 					Ref: "compute",
 					Inputs: sdk.StepInputs{
 						Mapping: map[string]any{"Arg0": []any{"$(trigger.outputs.cool_output)"}},
@@ -449,7 +449,7 @@ func TestBuilder_ValidSpec(t *testing.T) {
 					CapabilityType: capabilities.CapabilityTypeAction,
 				},
 				{
-					ID:  "custom-compute@1.0.0",
+					ID:  "custom_compute@1.0.0",
 					Ref: "compute again",
 					Inputs: sdk.StepInputs{
 						Mapping: map[string]any{"Arg0": "$(trigger.outputs.cool_output)"},
@@ -492,7 +492,7 @@ func TestBuilder_ValidSpec(t *testing.T) {
 			},
 			Actions: []sdk.StepDefinition{
 				{
-					ID:  "custom-compute@1.0.0",
+					ID:  "custom_compute@1.0.0",
 					Ref: "compute",
 					Inputs: sdk.StepInputs{
 						Mapping: map[string]any{
@@ -507,7 +507,7 @@ func TestBuilder_ValidSpec(t *testing.T) {
 					CapabilityType: capabilities.CapabilityTypeAction,
 				},
 				{
-					ID:  "custom-compute@1.0.0",
+					ID:  "custom_compute@1.0.0",
 					Ref: "compute again",
 					Inputs: sdk.StepInputs{
 						Mapping: map[string]any{

diff --git a/pkg/workflows/sdk/compute_generated.go b/pkg/workflows/sdk/compute_generated.go
diff --git a/pkg/workflows/sdk/compute_test.go b/pkg/workflows/sdk/compute_test.go
@@ -56,7 +56,7 @@ func TestCompute(t *testing.T) {
 			},
 			Actions: []sdk.StepDefinition{
 				{
-					ID:  "custom-compute@1.0.0",
+					ID:  "custom_compute@1.0.0",
 					Ref: "Compute",
 					Inputs: sdk.StepInputs{
 						Mapping: map[string]any{"Arg0": "$(trigger.outputs)"},

diff --git a/pkg/workflows/sdk/gen/compute.go.tmpl b/pkg/workflows/sdk/gen/compute.go.tmpl
@@ -57,7 +57,7 @@ func Compute{{.}}WithConfig[{{range  RangeNum .}}I{{.}} any, {{ end }}O any, C a
     }
 
     def := StepDefinition{
-       ID: "custom-compute@1.0.0",
+       ID: "custom_compute@1.0.0",
        Ref: ref,
        Inputs: input.ToSteps(),
        Config: cm,
@@ -114,7 +114,7 @@ func Compute{{.}}WithConfig[{{range  RangeNum .}}I{{.}} any, {{ end }}O any, C a
 // Compute{{.}}WithMetadata DO NOT USE, this functions is for internal local testing while other tools are being developed and is temporary
 func Compute{{.}}WithMetadata[{{range  RangeNum .}}I{{.}} any, {{ end }}O any](w *WorkflowSpecFactory, ref string, input Compute{{.}}Inputs[{{range RangeNum . }}I{{.}},{{ end }}], compute func(Runtime, {{range RangeNum . }}I{{.}},{{ end }} capabilities.RequestMetadata) (O, error)) ComputeOutputCap[O] {
     def := StepDefinition{
-		ID:     "custom-compute@1.0.0",
+		ID:     "custom_compute@1.0.0",
 		Ref:    ref,
 		Inputs: input.ToSteps(),
 		Config: map[string]any{

diff --git a/pkg/workflows/sdk/testutils/compute_capability.go b/pkg/workflows/sdk/testutils/compute_capability.go
@@ -14,7 +14,7 @@ type computeCapability struct {
 
 func (c *computeCapability) Info(ctx context.Context) (capabilities.CapabilityInfo, error) {
 	info := capabilities.MustNewCapabilityInfo(
-		"custom-compute@1.0.0", capabilities.CapabilityTypeAction, "Custom compute capability",
+		"custom_compute@1.0.0", capabilities.CapabilityTypeAction, "Custom compute capability",
 	)
 	info.IsLocal = true
 	return info, nil