Various updates to Observability Library #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix alert query type not instant when the query is instant - Add disable resolve message and uid to contact point - Add stacking mode to time series panel - Add multi and include all to custom variable - Use csv when the variable key and value is the same
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
- Fix delete notification template status code should be 204 - Add annotations to alerts - Derive notification templates name from file name
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
Atrax1
reviewed
Feb 4, 2025
Comment on lines
15
to
17
| if fileName == "notification-templates" { | ||
| fileName = "chainlink" | ||
| } |
There was a problem hiding this comment.
Because I'm using the filename as the template name. So a dev-platform-por.yaml will end up becoming dev-platform-por-slack-notification-template.
We can rename notification-templates.yaml to chainlink.yaml as well. Either way is fine.
There was a problem hiding this comment.
yes remove that logic I think better to rename file
Atrax1
previously approved these changes
Feb 4, 2025
|
@leeyikjiun Some test to fix as well |
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
leeyikjiun
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
reviewed
Feb 5, 2025
| @@ -45,7 +45,7 @@ func (c *Client) DeleteNotificationTemplate(name string) (DeleteNotificationTemp | |||
| } | |||
|
|
|||
| statusCode := resp.StatusCode() | |||
| if statusCode != 200 { | |||
| if statusCode != 204 { | |||
There was a problem hiding this comment.
Suggested change
| if statusCode != 204 { | |
| if statusCode != http.StatusNoContent { |
There was a problem hiding this comment.
Great suggestion! Let me fix all the status codes in one go in another PR. cc @Atrax1
jmank88
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of variable values:
Before:
crit : crit , error : error , warn : warn , info : info , debug : debugAfter:
error, warn, info, debug, critRequires
Supports