fix: add 30s timeout to context used to execute operations onchain #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when executing an operation, the timelock-worker called `bind.WaitMinted` with a context without an associated timeout. This meant that when there was a problem with the RPC or the network itself, the executer goroutine would get stuck waiting indefinitely for the call to return. And because all operations are called sequentially, the timelock effectively stopped working. With the added timeout, the context aborts the network call and the operation fails. The internal logic of the scheduler will take care of retrying a few minutes later.
graham-chainlink
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when executing an operation, the timelock-worker called
bind.WaitMintedwith a context without an associated timeout. This meant that when there was a problem with the RPC or the network itself, the executer goroutine would get stuck waiting indefinitely for the call to return. And because all operations are called sequentially, the timelock effectively stopped working.With the added timeout, the context aborts the network call and the operation fails. The internal logic of the scheduler will take care of retrying a few minutes later.