-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ai/explain #568
Draft
BBerabi
wants to merge
12
commits into
main
Choose a base branch
from
feat/ai/explain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feat/ai/explain #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+312
to
+333
const fileContent = readFileSync(filePath, 'utf8'); | ||
|
||
const derivationLineNumbers: Set<number> = new Set<number>(); | ||
for (const markerLocation of suggestion.markers!) { | ||
for (const markerPos of markerLocation.pos) { | ||
const lines = markerPos.rows; | ||
for (const line of lines) { | ||
derivationLineNumbers.add(line + 1); | ||
} | ||
} | ||
markerLocation.pos; | ||
} | ||
console.log('derivation lines: ', ...derivationLineNumbers); | ||
|
||
const derivationLines: string[] = []; | ||
const fileLines: string[] = fileContent.split('\n'); | ||
for (const derivationLineNumber of derivationLineNumbers) { | ||
derivationLines.push(fileLines.at(derivationLineNumber - 1)!); | ||
} | ||
let derivation = derivationLines.join(','); | ||
derivation = derivation.replace(/\t/g, ' '); | ||
console.log('derivation: ', derivation); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dunno what derivation is, but probably should be done on the LS side. Should just pass the issueID and the fixID and let LS do all the work.
Comment on lines
+350
to
+364
this.logger.info('generating fix explanation'); | ||
const { suggestion, diff } = message.args; | ||
|
||
let explanation: string = ''; | ||
explanation = await vscode.commands.executeCommand( | ||
SNYK_CODE_GENERATE_AI_EXPLANATION, | ||
/* derivation */ '', | ||
suggestion.rule, | ||
/* ruleMessage */ '', | ||
diff, | ||
); | ||
console.log('vscode: got fix explanation: ', explanation); | ||
void this.postSuggestMessage({ type: 'setFixExplanation', args: { explanation: explanation } }); | ||
|
||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!