Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circuit breaker #266
base: master
Are you sure you want to change the base?
Circuit breaker #266
Changes from all commits
90ff17b
8447a0f
9951f29
ed9985c
11d8005
72ab369
81ee70e
5c94eda
0a26e2f
20ed3ff
c617c66
64d694f
f42e74d
6f376eb
3581bd9
55afda2
6e34c70
09cc330
5be4f24
9139982
24e70b7
cf7dcea
4e01101
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we use PercentageThreshold here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really couldn't decide. This is internal config, so I would need to unwrap it everywhere where it's used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the CB constructor could also accept a BufferCapacity parameter, to allow configuring how much operations to buffer; we could provide a default of 100 there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by convention, side-effecting parameterless operations should have
()
, so:tryAcquire()
; buthasPermits
would have no()
, as it doesn't change the state