This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
ci: stop windows build on v1.16 branch #31893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihau
force-pushed
the
ignore-windows-build-for-116
branch
from
5daff5b to
48edd16
Compare
CriesofCarrots
approved these changes
May 31, 2023
|
I've been pinging the maintainer for weeks. but there's no response... MSxDOS/ntapi#15 (comment) |
|
hehe, i hacked up #31961
btw, how soon? i wonder my additional few hours to polish the pr should worth to restore windows build meanwhile. |
|
AFAIK the last discussion is here https://discord.com/channels/428295358100013066/560503042458517505/1100447210937790526 |
ryoqun
added a commit
to ryoqun/solana
that referenced
this pull request
Jun 6, 2023
This reverts commit 30f9e43.
ryoqun
added a commit
to ryoqun/solana
that referenced
this pull request
Jun 6, 2023
This reverts commit 30f9e43.
ryoqun
added a commit
that referenced
this pull request
Jun 6, 2023
* Shift crossbeam comment for upcoming 2nd patch... (#31963) * Patch ntapi to restore windows build (#31961) * Patch ntapi to restore windows build * Update Cargo.lock... * Add comment for justification of this patching MSxDOS/ntapi#11 MSxDOS/ntapi#12 * Revert "ci: stop windows building on master temporarily (#31353)" This reverts commit 2dcdfff. * Use solana-labs fork * Ugh.. * Patch ntapi more thoroughly (#31970) * Patch spl-token-cli build as well... * Patch sbf/Cargo.toml for consistency * Remove --locked for cli-arg based patch... (#31971) * Bump patched ntapi from v0.3.6 to v0.3.7 (#31981) * Revert "ci: stop windows build (#31893)" This reverts commit 30f9e43.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
due to the same reason with #31353. stop windows building on v1.16 for a while until we upgrade tokio crates successfully 😢