Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: introduce preloadDelay #151

Merged
merged 1 commit into from
Jun 18, 2024
Merged

client: introduce preloadDelay #151

merged 1 commit into from
Jun 18, 2024

Conversation

keegancsmith
Copy link
Member

This setting allows us to preload the openctx providers after a delay (which could be zero milliseconds). The intention is for Cody to set a reasonable value here (5s?) so that when a user does the first @ mention the providers have already been fetched.

Test Plan: added logging and observed the preload completing before activating the cody chat panel. Then loaded the cody chat panel and instantly do a mention. All OpenCtx providers where immediate.

Part of https://linear.app/sourcegraph/issue/CODY-1898/preload-openctx-providers-for-faster-user-typing

@keegancsmith keegancsmith requested a review from a team June 13, 2024 21:27
This setting allows us to preload the openctx providers after a
delay (which could be zero milliseconds). The intention is for Cody to
set a reasonable value here (5s?) so that when a user does the first @
mention the providers have already been fetched.

Test Plan: added logging and observed the preload completing before
activating the cody chat panel. Then loaded the cody chat panel and
instantly do a mention. All OpenCtx providers where immediate.
@keegancsmith
Copy link
Member Author

I'm out until Tuesday, if someone wants to take this over the finish line the two things left to do are:

  • merge and publish new npm packages
  • create cody PR which sets preloadDelay and updates deps for client and vscode-lib.

@keegancsmith keegancsmith merged commit 6e30381 into main Jun 18, 2024
11 checks passed
@keegancsmith keegancsmith deleted the k/preload branch June 18, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants